Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sonic_sfp]: Update config for multi-ASIC #141

Merged
merged 1 commit into from
Nov 26, 2020
Merged

[sonic_sfp]: Update config for multi-ASIC #141

merged 1 commit into from
Nov 26, 2020

Conversation

mudsut4ke
Copy link
Contributor

From this change #100 , It missing mapping of logical port names to ASIC instance on device that used platform.json

So this new change will fix it by add logical_to_asic mapping dict to a condition for device that used platform.json

Signed-off-by: Wirut Getbamrung [wgetbumr@celestica.com]

@mudsut4ke mudsut4ke mentioned this pull request Nov 13, 2020
Merged
judyjoseph
judyjoseph approved these changes Nov 26, 2020
View reviewed changes
Copy link
Contributor

@judyjoseph judyjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ! thanks

@judyjoseph judyjoseph merged commit fa0aaa6 into sonic-net:master Nov 26, 2020
@judyjoseph judyjoseph mentioned this pull request Nov 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@judyjoseph judyjoseph judyjoseph approved these changes

@jleveque jleveque Awaiting requested review from jleveque

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mudsut4ke @judyjoseph